ihloka/project-ihloka
2
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

WIP: refactor to ts #1

Draft
pixel wants to merge 9 commits from pixel/project-ihloka:main into main
pull from: pixel/project-ihloka:main
merge into: ihloka:main
Conversation 5 Commits 9 Files changed 17 +506 -15
pixel commented 2024-09-24 23:12:04 +02:00
First-time contributor
Copy link
No description provided.
pixel commented 2024-09-24 23:40:36 +02:00
Author
First-time contributor
Copy link

@maddy can you look at src/routes/register.ts L52? Is that variable needed for anything?

@maddy can you look at `src/routes/register.ts` L52? Is that variable needed for anything?
val commented 2024-09-24 23:44:40 +02:00
Owner
Copy link

@maddy can you look at src/routes/register.ts L52? Is that variable needed for anything?

Not for anything right now, however notification token support might be added in the future

> @maddy can you look at `src/routes/register.ts` L52? Is that variable needed for anything? Not for anything right now, however notification token support might be added in the future
pixel commented 2024-09-24 23:49:07 +02:00
Author
First-time contributor
Copy link

@maddy can you look at src/routes/register.ts L52? Is that variable needed for anything?

Not for anything right now, however notification token support might be added in the future

I'll try to add that when I'll add proper parsing of the data provided by client

> > @maddy can you look at `src/routes/register.ts` L52? Is that variable needed for anything? > > Not for anything right now, however notification token support might be added in the future I'll try to add that when I'll add proper parsing of the data provided by client
val commented 2024-09-24 23:50:04 +02:00
Owner
Copy link

one thing to note though, the UONET+ server expects an empty string afaik

one thing to note though, the UONET+ server expects an empty string afaik
pixel commented 2024-09-24 23:56:29 +02:00
Author
First-time contributor
Copy link

one thing to note though, the UONET+ server expects an empty string afaik

They might add something in the future

> one thing to note though, the UONET+ server expects an empty string afaik They might add something in the future
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:pixel-main
git switch pixel-main

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff pixel-main
git switch pixel-main
git rebase main
git switch main
git merge --ff-only pixel-main
git switch pixel-main
git rebase main
git switch main
git merge --no-ff pixel-main
git switch main
git merge --squash pixel-main
git switch main
git merge --ff-only pixel-main
git switch main
git merge pixel-main
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ihloka/project-ihloka#1
No description provided.
Delete branch "pixel/project-ihloka:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?